Some thoughts:
- Very nice that you've chosen VCA with independent CV and manual level control. This way, you can use the VCA as an attenuator as well.
- You have quite a few modules that are reasonibly big for what they do, aka they have very specific functionality. For example, Erica Synths Ring Mod, Dreadbox Dystopia, Behringer 305 EQ/Mixer/Output. Behringer Brains and Behringer Perfect Pitch 1 are also a bit wide. This is not a problem per se, just an observation.
- 4Ms Shuffling clock multiplier is nice but for a beginner rack I'd recommend this beside an ALM Pamela's New/Pro workout. This module is a bit more versatile since it can also do euclidean rhythms, LFOs and Quantazation. So the SCM is a nice addition for more experimental or polyrhythms.
- You mention that you use the Keystep 37. This has a sync in/output so you can link it to a clock module. I see there is no reset in/out on the Keystep (meaning that when you stop and start a sequence on the Keystep, it won't restart your divided clock for example). When you start with this rack, I think you can manage to go without a reset, but later on you can use a midi to clock or clock to midi module for this (like the expanders for the Pamela's New/Pro Workout modules)
- Note that the Behringer Perfect Pitch PP1 converts Midi NOTE data and not the clock! You don't really need this part I believe as the Keystep 37 has CV/Gate/Mod output as well. You can still get this module for the instrument interface, but just so you know.
- You got four oscillators and three filters (plus your guitar/bass), this is quite a lot for the size of rack that you have. Especially as you have only one sequencer (your Keystep). I'd advice to drop one or two of these oscillators and add more utilities or a more versatile effects unit. Such as a micro Ornament & Crime or a Disting EX.
- If you want more sequences at the same time, consider upgrading your Keystep 37 to the Keystep Pro. This will give you four melodic sequences or three melodic sequences + a drum sequencer, all via CV or Midi. Also has more versatile sequence management.